Skip to content

feat(copy): support advanced copy configuration with custom target paths#1711

Merged
xusd320 merged 6 commits intoutooland:masterfrom
BQXBQX:feature/enhanced-copy
Jan 22, 2025
Merged

feat(copy): support advanced copy configuration with custom target paths#1711
xusd320 merged 6 commits intoutooland:masterfrom
BQXBQX:feature/enhanced-copy

Conversation

@BQXBQX
Copy link
Contributor

@BQXBQX BQXBQX commented Dec 2, 2024

🎯 Features:

  • Added CopyConfig enum supporting both basic and advanced modes
  • Maintained backward compatibility with string[] format
  • Introduced {from, to} format for custom target paths
  • Enhanced copy plugin for both configuration types
  • Added automatic target directory creation

📝 Example Configuration:

{
  'copy': [
    'public',                       
    {                              
      'from': 'assets',
      'to': 'static'
    }
  ]
}

🔍 Details:

Summary by CodeRabbit

  • 新功能

    • 引入了 CopyConfig 枚举,支持基本和高级的文件复制配置。
    • 更新了 CopyPlugin,支持更灵活的源-目标路径关系,确保高级配置下的路径有效性。
    • 更新了构建参数,允许更复杂的文件复制配置。
  • 文档

    • 更新了配置文档,提供了更清晰的示例和说明,增强了可用性。
    • 增加了中文文档,确保用户更好地理解配置选项。
  • 测试

    • 增加了测试用例,验证文件复制行为的正确性。

- Add CopyConfig enum to support both basic and advanced copy modes
- Basic mode: maintains backward compatibility with string[] format
- Advanced mode: supports {from: string, to: string} format for custom paths
- Update copy plugin to handle both configuration formats
- Ensure target directories are created automatically

Example config:
{
  'copy': [
    'public',                              // basic mode
    { 'from': 'assets', 'to': 'static' }  // advanced mode
  ]
}
@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2024

Walkthrough

该拉取请求引入了一个新的枚举类型 CopyConfig,用于表示文件复制的不同配置,支持基本字符串和包含 fromto 字段的高级配置。Config 结构体中的 copy 字段类型从 Vec<String> 修改为 Vec<CopyConfig>。同时,CopyPlugin 的实现也进行了相应的修改,以支持这两种配置类型,更新了文件复制的逻辑和路径处理。此外,相关文档和测试用例也进行了相应的更新,以反映这些变化。

Changes

文件路径 更改摘要
crates/mako/src/config.rs 新增枚举 CopyConfig,并将 Config 结构体中的 copy 字段类型更新为 Vec<CopyConfig>
crates/mako/src/plugins/copy.rs 修改 CopyPlugin 的实现,更新 watchcopy 方法以支持 BasicAdvanced 配置类型。
crates/binding/src/lib.rs 更新 BuildParams 结构体中的 copy 字段类型,从 string[] 修改为 `(string
docs/config.md 更新文档,修改 copy 配置项类型,增加示例以增强可用性。
docs/config.zh-CN.md 更新中文文档,修改 copy 配置项类型,增加示例以增强可用性。
e2e/fixtures/config.copy/expect.js 增加对文件复制行为的测试断言,确保新配置的正确性。
e2e/fixtures/config.copy/mako.config.json 更新配置文件,增强 "copy" 指令,支持更复杂的复制结构。
packages/bundler-mako/index.js 更新 checkConfig 函数,增强对 copy 配置的验证逻辑,提供更清晰的错误信息。
packages/mako/binding.d.ts 更新 BuildParams 接口中的 copy 属性类型,允许更复杂的复制操作。

Possibly related PRs

Suggested reviewers

  • sorrycc

Poem

在兔子洞中忙碌跳,
复制文件不再烦恼。
基本高级皆可选,
配置灵活乐无穷。
兔子欢跳庆新生,
代码更新真有趣! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Outside diff range and nitpick comments (1)
crates/mako/src/plugins/copy.rs (1)

71-77: 在复制前验证源路径是否存在

在复制操作中,如果源路径不存在,copy函数可能会失败。建议在复制前检查源路径的存在性,并在不存在时提供有意义的错误消息或跳过复制。

示例修改:

match config {
    CopyConfig::Basic(src) => {
        let src = context.root.join(src);
+       if !src.exists() {
+           eprintln!("Source path {:?} does not exist", src);
+           continue;
+       }
        debug!("copy {:?} to {:?}", src, dest);
        copy(&src, dest)?;
    }
    // 其他分支...
}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 89d7c53 and a3ddec7.

📒 Files selected for processing (2)
  • crates/mako/src/config.rs (2 hunks)
  • crates/mako/src/plugins/copy.rs (4 hunks)
🔇 Additional comments (1)
crates/mako/src/config.rs (1)

147-147: 确保所有使用config.copy的代码已更新

Config结构体中的copy字段类型从Vec<String>更改为Vec<CopyConfig>,这可能影响到依赖此字段的其他代码。请确认所有使用config.copy的代码都已更新以适应新的类型。

生成以下脚本以查找所有使用config.copy的代码位置:

✅ Verification successful

Let me check the implementation in the copy plugin to verify if it's already compatible with the new type.


代码已正确适配新的类型变更

从代码实现来看,crates/mako/src/plugins/copy.rs中的代码已经完全适配了Vec<CopyConfig>的新类型,正确处理了CopyConfig::BasicCopyConfig::Advanced两种情况。没有发现其他使用config.copy的地方需要更新。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 描述:查找所有使用`config.copy`的代码,确保兼容新的类型

rg 'config\.copy' --glob '!crates/mako/src/config.rs'

Length of output: 225


Script:

#!/bin/bash
# Check the implementation in copy.rs to see how config.copy is used
rg -A 10 'config\.copy' crates/mako/src/plugins/copy.rs

Length of output: 1012

Comment on lines +34 to +39
for config in context.config.copy.iter() {
let src = match config {
CopyConfig::Basic(src) => context.root.join(src),
CopyConfig::Advanced { from, .. } => context.root.join(from),
};

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

建议检查源路径是否存在

当前代码在处理src之前未检查其是否存在,可能会在源路径不存在时引发错误。建议在处理之前添加对src存在性的验证,并在不存在时进行适当的错误处理或日志记录。

示例修改:

for config in context.config.copy.iter() {
    let src = match config {
        CopyConfig::Basic(src) => context.root.join(src),
        CopyConfig::Advanced { from, .. } => context.root.join(from),
    };

+   if !src.exists() {
+       eprintln!("Source path {:?} does not exist", src);
+       continue;
+   }

    if src.exists() {
        debug!("watch {:?}", src);
        // ...
    }
}

Committable suggestion skipped: line range outside the PR's diff.

Comment on lines 81 to 89
let target = dest.join(to.trim_start_matches("/"));

if !target.exists() {
fs::create_dir_all(&target)?;
}

debug!("copy {:?} to {:?}", src, target);
copy(&src, &target)?;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

防止目标路径的目录遍历漏洞

在处理CopyConfig::Advanced配置时,to字段可能包含恶意路径(如../),导致文件复制到意外的位置。建议对目标路径进行规范化和验证,确保目标路径位于预期的目标目录中,防止潜在的安全问题。

示例修改:

let target = dest.join(to.trim_start_matches("/"));

+ let target = target.canonicalize()?;
+ let dest_canonical = dest.canonicalize()?;
+ if !target.starts_with(&dest_canonical) {
+     return Err(anyhow!("Invalid target path: {:?}", target));
+ }

if !target.exists() {
    fs::create_dir_all(&target)?;
}

Committable suggestion skipped: line range outside the PR's diff.

Comment on lines +126 to +132
#[derive(Deserialize, Serialize, Debug)]
#[serde(untagged)]
pub enum CopyConfig {
Basic(String),
Advanced { from: String, to: String },
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

CopyConfig添加配置验证

CopyConfig中的fromto字段直接来自用户配置,可能包含非法或不安全的路径。建议在配置解析时添加路径验证,确保路径不存在注入风险并且指向合法的位置。

Add path canonicalization and validation to ensure target paths remain within the destination directory
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
crates/mako/src/plugins/copy.rs (1)

71-78: 建议优化基础配置的错误处理

基础配置的处理逻辑过于简单,建议添加更详细的错误处理和日志记录。

建议修改如下:

 CopyConfig::Basic(src) => {
     let src = context.root.join(src);
+    debug!("正在处理基础复制配置");
+    if !src.exists() {
+        debug!("源路径不存在: {:?}", src);
+        continue;
+    }
     debug!("copy {:?} to {:?}", src, dest);
     copy(&src, dest)?;
 }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a3ddec7 and 464b49c.

📒 Files selected for processing (1)
  • crates/mako/src/plugins/copy.rs (4 hunks)
🔇 Additional comments (2)
crates/mako/src/plugins/copy.rs (2)

34-39: 建议在处理源路径之前进行验证

这段代码在处理配置时缺少对源路径的预先验证。虽然后续有exists()检查,但建议在匹配过程中就进行更全面的验证。

建议修改如下:

 for config in context.config.copy.iter() {
     let src = match config {
         CopyConfig::Basic(src) => context.root.join(src),
         CopyConfig::Advanced { from, .. } => context.root.join(from),
     };
+    
+    if !src.exists() {
+        debug!("跳过不存在的源路径: {:?}", src);
+        continue;
+    }

79-96: 🛠️ Refactor suggestion

建议增强高级配置的路径处理和安全性

当前的路径验证逻辑可以进一步加强,同时建议添加更多的安全检查。

建议修改如下:

 CopyConfig::Advanced { from, to } => {
     let src = context.root.join(from);
+    if !src.exists() {
+        debug!("源路径不存在: {:?}", src);
+        continue;
+    }
     let target = dest.join(to.trim_start_matches("/"));
 
     let target = target.canonicalize()?;
     let dest_canonical = dest.canonicalize()?;
     if !target.starts_with(&dest_canonical) {
-        return Err(anyhow!("Invalid target path: {:?}", target));
+        return Err(anyhow!("目标路径不安全: {:?}", target));
     }
 
+    // 验证目标路径不包含特殊字符
+    if to.contains("..") {
+        return Err(anyhow!("目标路径包含非法字符: {:?}", to));
+    }
+
     if !target.exists() {
+        debug!("创建目标目录: {:?}", target);
         fs::create_dir_all(&target)?;
     }
 
     debug!("copy {:?} to {:?}", src, target);
     copy(&src, &target)?;
 }

Likely invalid or redundant comment.

Comment on lines 83 to 87
let target = target.canonicalize()?;
let dest_canonical = dest.canonicalize()?;
if !target.starts_with(&dest_canonical) {
return Err(anyhow!("Invalid target path: {:?}", target));
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

路径规范化可能导致错误

使用canonicalize()进行路径规范化时,如果路径不存在会导致错误。建议在这种情况下使用更健壮的处理方式。

建议添加错误处理:

-    let target = target.canonicalize()?;
-    let dest_canonical = dest.canonicalize()?;
+    let target = target.canonicalize().map_err(|e| {
+        anyhow!("无法规范化目标路径 {:?}: {}", target, e)
+    })?;
+    let dest_canonical = dest.canonicalize().map_err(|e| {
+        anyhow!("无法规范化输出目录 {:?}: {}", dest, e)
+    })?;
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
let target = target.canonicalize()?;
let dest_canonical = dest.canonicalize()?;
if !target.starts_with(&dest_canonical) {
return Err(anyhow!("Invalid target path: {:?}", target));
}
let target = target.canonicalize().map_err(|e| {
anyhow!("无法规范化目标路径 {:?}: {}", target, e)
})?;
let dest_canonical = dest.canonicalize().map_err(|e| {
anyhow!("无法规范化输出目录 {:?}: {}", dest, e)
})?;
if !target.starts_with(&dest_canonical) {
return Err(anyhow!("Invalid target path: {:?}", target));
}

- Updated the type of the `copy` property in the `BuildParams` interface to support both `string` and `{ from: string; to: string }`.
- Ensured the `copy` configuration is properly validated to handle both types.
- Updated the `copy` property type in the configuration documentation to reflect the change from `string[]` to `(string | { from: string; to: string })[]`.
- Clarified that the `copy` configuration can now accept both strings and objects with `from` and `to` properties.
- Update config.copy test fixtures to cover from/to pattern
- Add assertions for copied files in new location
- Adjust copy plugin path validation
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (6)
e2e/fixtures/config.copy/mako.config.json (1)

2-8: 配置示例清晰展示了新旧两种格式

配置文件很好地展示了两种复制模式的用法:

  • 基础模式:使用字符串格式 "src/assets"
  • 高级模式:使用对象格式 {"from": "src/assets", "to": "assets-from-to"}

建议在项目文档中添加这个示例,以帮助用户理解新的配置选项。

e2e/fixtures/config.copy/expect.js (1)

5-9: 建议增加更多测试用例

当前测试覆盖了基本功能,建议添加以下测试场景:

  1. 源路径不存在的情况
  2. 目标路径包含特殊字符的情况
  3. 复制大量文件时的性能测试
  4. 复制时发生冲突的情况
crates/mako/src/plugins/copy.rs (2)

71-77: 建议优化错误处理

在基础模式下的复制操作中,建议添加更详细的错误上下文信息,以便于调试:

-copy(&src, dest)?;
+copy(&src, dest).map_err(|e| {
+    anyhow!("复制文件失败 - 从 {:?} 到 {:?}: {}", src, dest, e)
+})?;

Line range hint 115-134: 建议添加进度报告功能

对于大文件或大量文件的复制操作,建议添加进度报告功能:

let options = fs_extra::dir::CopyOptions::new()
    .content_only(true)
    .skip_exist(false)
+   .buffer_size(64 * 1024)  // 优化缓冲区大小
    .overwrite(true);
+let handle = |process_info: fs_extra::TransitProcess| {
+    debug!(
+        "复制进度: {}/{} bytes",
+        process_info.copied_bytes,
+        process_info.total_bytes
+    );
+    fs_extra::dir::TransitProcessResult::ContinueOrAbort
+};
-fs_extra::dir::copy(&entry, dest, &options)?;
+fs_extra::dir::copy_with_progress(&entry, dest, &options, handle)?;
docs/config.zh-CN.md (1)

119-119: 文档更新准确反映了新的复制配置选项

类型定义和默认值的说明清晰准确。建议添加一个配置示例来帮助用户更好地理解新的对象格式用法。

建议添加如下示例:

### copy

- 类型:`(string | { from: string; to: string })[]`
- 默认值:`["public"]`

指定需要复制的文件或目录。默认情况下,会将 `public` 目录下的文件复制到输出目录。

+例如:
+```json
+{
+  "copy": [
+    "public",
+    { "from": "./src/assets", "to": "static/assets" }
+  ]
+}
+```
docs/config.md (1)

119-119: 建议添加配置示例

文档中已更新了 copy 配置的类型定义,但建议添加使用新的 { from, to } 对象格式的具体示例,以帮助用户更好地理解如何使用这个新特性。例如:

{
  "copy": [
    "public",  // 基础字符串格式
    { 
      "from": "assets/images",  // 源路径
      "to": "static/img"        // 目标路径
    }
  ]
}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 464b49c and f2c75e3.

📒 Files selected for processing (8)
  • crates/binding/src/lib.rs (1 hunks)
  • crates/mako/src/plugins/copy.rs (4 hunks)
  • docs/config.md (1 hunks)
  • docs/config.zh-CN.md (1 hunks)
  • e2e/fixtures/config.copy/expect.js (1 hunks)
  • e2e/fixtures/config.copy/mako.config.json (1 hunks)
  • packages/bundler-mako/index.js (1 hunks)
  • packages/mako/binding.d.ts (1 hunks)
🔇 Additional comments (5)
crates/mako/src/plugins/copy.rs (2)

34-39: 建议检查源路径是否存在

当前代码在处理src之前未检查其是否存在,可能会在源路径不存在时引发错误。建议在处理之前添加对src存在性的验证。


79-94: ⚠️ Potential issue

建议加强路径安全性和错误处理

  1. 路径安全:
let target = dest.join(to.trim_start_matches("/"));
+let target = target.canonicalize().map_err(|e| {
+    anyhow!("无法解析目标路径 {:?}: {}", target, e)
+})?;
+let dest_path = dest_path.canonicalize().map_err(|e| {
+    anyhow!("无法解析输出目录 {:?}: {}", dest_path, e)
+})?;
  1. 目录创建:
-if !target.exists() {
-    fs::create_dir_all(&target)?;
+if !target.exists() {
+    fs::create_dir_all(&target).map_err(|e| {
+        anyhow!("创建目标目录失败 {:?}: {}", target, e)
+    })?;
}
packages/mako/binding.d.ts (1)

137-137: LGTM: Type definition correctly supports both basic and advanced copy configurations

The updated type definition properly supports both the legacy string array format and the new object format with from and to fields, ensuring type safety and backward compatibility.

crates/binding/src/lib.rs (1)

77-77: LGTM: Rust implementation aligns with TypeScript definition

The BuildParams struct's copy field type has been correctly updated to support both string and object configurations, maintaining consistency with the TypeScript interface.

packages/bundler-mako/index.js (1)

256-258: 实现正确且错误提示清晰

配置校验逻辑实现完善:

  • 正确支持字符串和对象两种格式
  • 对象格式必须包含 fromto 字段
  • 错误提示信息清晰明确

- Add directory cleanup when path validation fails
- Use canonicalized paths for more reliable path validation
- Add concatenateModules option type to BuildParams
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
crates/mako/src/plugins/copy.rs (1)

79-99: 建议添加源路径存在性检查

在进行复制操作之前,应该验证源路径是否存在,以避免不必要的操作和潜在的错误。

CopyConfig::Advanced { from, to } => {
    let src = context.root.join(from);
+   if !src.exists() {
+       debug!("源路径不存在,跳过复制: {:?}", src);
+       continue;
+   }
    let target = dest.join(to.trim_start_matches("/"));
    // ... 后续代码 ...
}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f2c75e3 and 459b3a0.

📒 Files selected for processing (2)
  • crates/mako/src/plugins/copy.rs (4 hunks)
  • packages/mako/binding.d.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/mako/binding.d.ts
🔇 Additional comments (2)
crates/mako/src/plugins/copy.rs (2)

34-39: 建议在处理配置前添加源路径验证

当前代码在处理配置之前没有验证源路径是否存在,这可能导致在后续处理中出现问题。建议在匹配配置类型之后、使用路径之前添加验证。

for config in context.config.copy.iter() {
    let src = match config {
        CopyConfig::Basic(src) => context.root.join(src),
        CopyConfig::Advanced { from, .. } => context.root.join(from),
    };

+   if !src.exists() {
+       debug!("跳过不存在的源路径: {:?}", src);
+       continue;
+   }

    if src.exists() {
        debug!("watch {:?}", src);
        // ...
    }
}

88-95: 🛠️ Refactor suggestion

建议增强路径规范化的错误处理

当前的路径规范化错误处理可能不够健壮,特别是在处理不存在的路径时。建议添加更详细的错误信息和恢复机制。

-   let canonical_target = target.canonicalize()?;
-   let canonical_dest_path = dest.canonicalize()?;
+   let canonical_target = target.canonicalize().map_err(|e| {
+       anyhow!("无法规范化目标路径 {:?}: {}", target, e)
+   })?;
+   let canonical_dest_path = dest.canonicalize().map_err(|e| {
+       anyhow!("无法规范化输出目录 {:?}: {}", dest, e)
+   })?;

    if !canonical_target.starts_with(&canonical_dest_path) {
        if was_created {
-           fs::remove_dir_all(&target)?;
+           if let Err(e) = fs::remove_dir_all(&target) {
+               debug!("清理无效目标目录失败: {:?}, 错误: {}", target, e);
+           }
        }
        return Err(anyhow!("无效的目标路径: {:?}", target));
    }

Likely invalid or redundant comment.

Comment on lines +83 to +87
let was_created = if !target.exists() {
fs::create_dir_all(&target).is_ok()
} else {
false
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

建议改进目录创建的错误处理

当前代码使用is_ok()简单处理目录创建的结果,建议添加更详细的错误处理和日志记录。

-   let was_created = if !target.exists() {
-       fs::create_dir_all(&target).is_ok()
-   } else {
-       false
-   };
+   let was_created = if !target.exists() {
+       match fs::create_dir_all(&target) {
+           Ok(_) => {
+               debug!("成功创建目标目录: {:?}", target);
+               true
+           }
+           Err(e) => {
+               debug!("创建目标目录失败: {:?}, 错误: {}", target, e);
+               false
+           }
+       }
+   } else {
+       false
+   };
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
let was_created = if !target.exists() {
fs::create_dir_all(&target).is_ok()
} else {
false
};
let was_created = if !target.exists() {
match fs::create_dir_all(&target) {
Ok(_) => {
debug!("成功创建目标目录: {:?}", target);
true
}
Err(e) => {
debug!("创建目标目录失败: {:?}, 错误: {}", target, e);
false
}
}
} else {
false
};

@xusd320 xusd320 self-requested a review January 21, 2025 15:40
@xusd320 xusd320 merged commit 8bdd985 into utooland:master Jan 22, 2025
elrrrrrrr pushed a commit that referenced this pull request Jul 9, 2025
* fix: env_replacer should not replace user defined variable in scope (#1577)

* fix: env_replacer should not replace user defined variable in scope

* test: add test cases for env_replacer

* chore: code style

* release: @umijs/mako@0.8.11

* chore: bundler-mako@0.8.11

* docs: add changelog for v0.8.11

* fix(tree-shaking): detect export var side effects (#1579)

* test: ✅ add a failure test

* fix: 🐛 add is pure detection in export var decl

* fix: bad output when chunk_loading_global containing quotation mark (#1582)

* chore: ➕ add a subdot cli tool script (#1585)

* fix(win): copy don't work under windows (#1587)

* fix(win): module id should be win_pathed (#1588)

* feat(tree-shaking): optimize import namespace used all exports to partial used of source modules (#1584)

* test: ✅ add failure test case

* feat: ✨ add collect prop explicit field

* feat: ✨ collect explicit member prop access to optizmize used export in dep module
replace USE ALL export to partial used exports

* fix: dedestructuring before collect ExplicitProps

* test: ✅ add back trace env var

* test: ✅ update test case

* fix: 🐛 add globals and helpers

---------

Co-authored-by: Jinbao1001 <nodewebli@gmail.com>

* fix: merge mako config (#1578)

* fix: merge mako config

* fix: merge mako config

* fix:clear deps should not panic when module not found (#1581)

* fix:clear deps should not panic when module not found

* chore: use tracing warn

* fix: delete log

* Revert "fix: merge mako config (#1578)" (#1589)

This reverts commit c08821d.

* fix: watch too many file error (#1550)

* fix: watch too many file error

* chore: delete print

* chore: delete log

* release: @umijs/mako@0.8.8-rc.1

* fix: conflict

* feat: support numeric module Id (#1561)

* feat: moduleIdStrategy support numberous

* fix: typos

* fix: typos

* fix: change name

* fix: typos

* release: @umijs/mako@0.8.12

* chore: fix typo and doc (#1591)

* fix: chunk_loading_global  (#1590)

* fix: bad entry output when chunk_loading_global containing singe quote

* test: add test cases for chunk_loading_global

* docs: update

* chore: update lock

* chore: remove useless dependencies (#1595)

* refactor: 🔥 rm ci warn logs (#1596)

* fix: devServer put static serve proxy after umi proxy middleware  (#1558)

* fix: fix umi load html file failed,

* test: add umi devServer test case

* fix: typo

* fix: hmr on hyper-static-file error

* fix: import expect.mjs error on github workflow.

* fix: import expect.mjs error on github workflow.

* fix: 🐛 expect for error case

* fix: 🐛 dev.hmr dont stop

* fix: 🐛 add OKAM env

* fix: 🐛 wait for mako server

* fix: 🐛 kill by children process

* test: ✅ add umi.css

* refactor: 🎨 unify expect file

* feat: export killMakoDevServer from test-hmr.mjs, make it public for all test case

* test: ✅ unify expect file

* chore: ➕ use express-http-proxy for static proxy

* feat: ✨ better mako static proxy

* test: ✅ support umi dev test with local mako

* chore: ⬆️ update pnpm-lock

* chore: 🎨

* fix: 🐛 ignore children process killed error

---------

Co-authored-by: huanyu.why <huanyu.why@antgroup.com>
Co-authored-by: pshu <pishu.spf@antfin.com>

* fix(tree-shaking): object spread transform should go before deconstructing (#1598)

* fix: 🐛 deconstructing needs object spread transform first

* test: ✅ add guardian syntax

* release: @umijs/mako@0.8.13-canary.20240918.1

* chore: bundler-mako@0.8.13-canary.20240918.1

* chore: 🎨 thread name  after mako (#1601)

* refactor: 🎨 rayon is not friendly to js users

* chore: ✏️ rename tokio worker with mako

* revert:  import namespace optimize  (#1606)

* Revert "fix(tree-shaking): object spread transform should go before deconstructing (#1598)"

This reverts commit 9434d99.

* Revert "feat(tree-shaking): optimize import namespace used all exports to partial used of source modules (#1584)"

This reverts commit 81a52f8.

* chore: 🔧 update mako clean script

* release: @umijs/mako@0.8.13

* chore: bundler-mako@0.8.13

* docs: change log 0923 (#1607)

* docs: 📝 change log

* docs: 📝 change log 0923

* chore: ✏️

* fix: 🐛 turn off express-http-proxy's keep alive (#1612)

* fix: 🐛 turn off express-http-proxy's keep alive

* refactor: 🔥 remove timeout config

* release: @umijs/mako@0.8.14

* chore: bundler-mako@0.8.14

* refactor: napi threadsafe function (#1608)

* refactor: napi threadsafe function

* chore: update binding typings

* refactor: code pieces

* fix: catch napi tsfn promise rejection

* chore: update binding typings

* docs: 📝  change log 20240925 (#1613)

* feat: disable webp to base64 (#1602)

* feat: init

* fix: context

* fix: no use

* fix: typos

* fix: typos

* fix: typos

* fix: typos

* fix(bundler-mako): experimental config should be merged deeply (#1617)

* refactor: config codes organization (#1618)

* refactor: config codes organization

* fix: typos

* refactor: config parse error

* fix: clickToComponent don't work (#1620)

* fix: duplicate_package_checker panic when no package.json is supplied (#1621)

* fix: file_stem index out of bound (#1623)

* feat: add resolve_id plugin hook (#1625)

* feat: add resolve_id plugin hook

* chore: update docs

* feat: add external

* release: @umijs/mako@0.8.15

* chore: bundler-mako@0.8.15

* docs: changelog for 0.8.15

* chore: update the release instruction (#1627)

* refactor: code-splitting config (#1629)

* feat: add loadInclude plugin hook (#1630)

* feat: add { isEntry } for resolve_id plugin hook (#1631)

* feat/upgrade swc (#1444)

* 🚧

* 🚧 a basic working version

* chore: 🚨 lint happy

* refactor: 🎨 adjust to new swc

* refactor: 🎨 remove deprecated methods

* chore: 🚨 lint happy

* feat: ✨ update swc emotion

* chore: 🔧 remove useless profile in sub crate

* chore: 🔧 add back emotion plugin

* refactor: 🎨 add back merge source map

* test: ✅ hot update js file served by hyper static, it use text/javascript

* chore: 🔧 lock update

* chore: 🔧 clean up swc core feature

* refactor: 🎨 fix breaking change of ctxt of span

* fix: 🐛 ctxt apply mark

* refactor: 🎨 use DUMMY CTXT instead of SyntaxContext::empty()

* chore: ⬆️  temperal use mdxjs from kdy branch

* feat: ✨ re-enable mdxjs

* feat: ✨ swc_core 0.100.1

* chore: 🙈  ignore fmt in fixtures

* chore: 🚨 lint happy

* chore: ⬆️  swc_common

* chore: ✏️ typo

* release: @umijs/mako@0.8.1-canary.20240812.1

* chore: bundler-mako@0.8.1-canary.20240812.1

* chore: ⬆️ swc_core 0.100.6

* release: @umijs/mako@0.8.1-canary.20240814.2

* chore: bundler-mako@0.8.1-canary.20240814.2

* chore: 🚨 lint happy

* chore: 🔧 CI build bindings

* chore: 🔧 fix build docker

* refactor: 🔥 remove  aarch64-unknown-linux-gnu

* chore: 🔧 create tar

* chore: 🙈

* release: @umijs/mako@0.8.3-canary.20240820.1

* chore: bundler-mako@0.8.3-canary.20240820.1

* chore: 🔧 wrong donwload param

* chore: 🔧 upload download actions should be same version

* chore: 🔧 try codecov in ci

* refactor: 🔥 remove unnecessary target

* refactor: 🎨 use swc comments

* fix: 🐛 after upgrade to swc_core it should remove paren before minifiy

* refactor: 🎨 move dummy ctxt defintion to ast mod

* chore: 🚨 lint happy

* release: @umijs/mako@0.8.8-canary.20240902.1

* chore: bundler-mako@0.8.8-canary.20240902.1

* release: @umijs/mako@0.8.8-canary.20240903.3

* chore: bundler-mako@0.8.8-canary.20240903.3

* refactor: 🎨 use VisitMut + Fold code style

* chore: ⬆️ update pnpm-lock

* chore: 🙈

* revert: ⏪ delete musl bindin

* release: @umijs/mako@0.8.9-canary.20240909.1

* chore: bundler-mako@0.8.9-canary.20240909.1

* release: @umijs/mako@0.8.11-canary.20240910.1

* chore: bundler-mako@0.8.11-canary.20240910.1

* fix: 🐛 use chars() instead of bytes()

* fix: 🐛 unescape html entity by html escape crate

* release: @umijs/mako@0.8.14-canary.20240924.1

* chore: bundler-mako@0.8.14-canary.20240924.1

* release: @umijs/mako@0.8.15-canary.20240927.1

* chore: bundler-mako@0.8.15-canary.20240927.1

* fix: hash not stable (&revert import * as optimize)   (#1610)

* Revert "revert:  import namespace optimize  (#1606)"

This reverts commit a485358.

* fix: hash not stable

* fix: deps sort not stable

* fix: deps sort not stable

* fix: deps sort not stable

* fix: delete binding

* fix: var name

* chore: iter to into

* fix: format

* release: @umijs/mako@0.9.0

* chore: bundler-mako@0.9.0

* docs: 📝  changelog 0.9.0

* fix: duplicate_package_checker panic when package.json has no version field (#1634)

* feat: magic comment chunk name (#1628)

* refactor: code-splitting config

* feat: support magic comment chunk name basically

* fix: magic comment chunk name for webworker

* refactor: use ImportOptions to represent option from magic comments

* fix: dep replacer when magic comments chunk name existed

* test: update test cases for magic comments chunk name

* fix: dep replacer when dynamic import depencies is missing

* chore: remove useless codes

* refactor: code styles

* docs: add todo for ChunkId

* test: fix visitors::dynamic_import::tests::test_dynamic_import

* test: fix test::hmr

* fix: dep replacer when dynamic import css modules or moduleIdStrategy is hashed

* chore: remove meaning less changes

* test: enable magic comment chunk name in fixtures/umi

* docs: add docs for magic comment chunk name

* feat: support webpackIgnore and makoIgnore magic comment (#1636)

* feat: support webpackIgnore and makoIgnore magic comment

* chore: fmt

* chore: rename magic_comment_chunk_name to magic_comment

* chore: fix typo

* feat: add transform plugin hook (#1637)

* feat: add transform plugin hook

* docs: add docs

* chore: fmt

* chore: perf

* feat: add transformInclude plugin hook (#1639)

* feat: add transformInclude plugin hook

* chore: fmt

* Fix: import namespace optimize panic with nested for of stmt (#1640)

* test: ✅ add import namespace optimize panic test case

* fix: 🐛 fix nested for of stmt panic

* release: @umijs/mako@0.9.2-canary.20241016.1

* chore: bundler-mako@0.9.2-canary.20241016.1

* release: @umijs/mako@0.9.2

* chore: bundler-mako@0.9.2

* docs: 📝  changelog 0.9.2

* feat: add buildEnd plugin hook (#1644)

* feat: add enforce plugin hook (#1646)

* feat: add enforce plugin hook

* chore: code style

* chore: code style

* chore: fix lint

* chore: 🎨 add missing binding type

* release: @umijs/mako@0.9.3-canary.20241016.1

* chore: bundler-mako@0.9.3-canary.20241016.1

* feat: add writeBundle plugin hook (#1650)

* feat: add watch_changes plugin hook (#1651)

* feat: add watch_changes plugin hook

* chore: fix lint

* chore: fix ts define

* fix: mako on windows don't work (#1652)

* fix: devtool sourcemap explosion in windows (#1653)

* chore: remove dead code

* fix: should not re-group when span changed (#1654)

* fix: umd should be import as cjs (#1642)

* fix: umd should be import as cjs

* refactor: 🎨 just short circuit typeof define to prevent define takes effect

* revert: ⏪ binding.d.ts

---------

Co-authored-by: pshu <pishu.spf@antfin.com>

* fix: 🐛 add process.env.SOCKET_SERVER define to prevent process polyfilll (#1655)

* release: @umijs/mako@0.9.3-canary.20241023.1

* chore: bundler-mako@0.9.3-canary.20241023.1

* release: @umijs/mako@0.9.3

* chore: bundler-mako@0.9.3

* docs: changelog for 0.9.3

* fix: hmr with magic comment chunk name (#1663)

* feat: enable magicComment features by default (#1667)

* feat(bundler-mako): add moduleIdStrategy to supportMakoConfigKeys (#1664)

* fix: async module in circular dependence (#1659)

* test: ✅ add test async module in circular dependencies

* refactor: 🎨 handle async polution by traversal

* refactor: 🎨 use default over expect

* feat: compatible codeSplitting config with umi (#1669)

* feat: compatible codeSplitting config with umi

* test: fix e2e code-splitting.granular

* fix: umi codeSplitting: depPerChunk

* Feat/benchmark workflows (#1671)

* feat: benchmark-workflows

* fix: 修改Github Secrets

* release: @umijs/mako@0.9.4

* chore: bundler-mako@0.9.4

* docs: 📝 changelog 0.9.4

* chore: Optional parameters (#1679)

* chore: Optional parameters

* Update index.ts

* fix: skip module should skip async module (#1662)

* release: @umijs/mako@0.9.5

* chore: bundler-mako@0.9.5

* docs: update changelog

* docs: update changelog

* feat(ssu): handle dependence changing while watching (#1690)

* refactor: 🎨 add after update aspect for rebuild cached modules

* refactor: 🎨 add next_build aspect in build_my_modify

* feat: ✨ 区分 ssu firstbuild 和  updating 两者状态

* fix: pnpm workspace watch too many files (#1684)

* fix: ✅ ts annotated declare variable treat as top level variable (#1682)

* test: ✅ add ts declare annotated variable as top level

* refactor: 🎨 mv clean syntax context to visitors folder

* fix: 🐛 strip ts/tsx first, then do normal transform

* feat: move ensure runtime to entry  (#1660)

* feat: ✨ add ensure2 replace in dynamic replace

* feat: ✨ ensure 2 runtime

* feat: ✨ add experimental centralEnsure config

* refactor: 🎨 add struct ReslvedReplaceInfo

* feat: ✨ add central ensure plugin

* refactor: 🎨 extract module ensure map

* refactor: 🎨 add back chunk id in replace info

* refactor: 🎨 fix case one source with different import type

* refactor: 🎨 extract hmr runtime update code aspect

* release: @umijs/mako@0.9.6-canary.20241107.1

* chore: bundler-mako@0.9.6-canary.20241107.1

* feat: keep unresolved nodejs require (#1689)

* fix: regexpr for nodejs intenal modules igonre

* feat: not replace unresolved nodejs require to __mako_require__

* fix: define util require should be __mako_require__

* feat: add expreriental.keep_unresolved_node_require

* feat: add expreriental.ignore_non_literal_require

* chore: 🔥 remove unused fn

* release: @umijs/mako@0.9.6

* chore: bundler-mako@0.9.6

* docs: changelog for 0.9.6

* fix(SSU): 🐛 in case external not avaible to all  entries (#1698)

* fix(SSU): 🐛 in case external not avaible to all  entries

* refactor: 🎨 explict ignore the error

* fix: devserver response header add cacheControl no-cache (#1692)

* fix: add no-cache

* feat: add cross origin

* fix: resonse header add cors and no_cache for all branch (#1699)

* fix: judge devServer instead of writeToDisk

* fix: add branch header

* refactor: 🎨 static file with 0 ages

---------

Co-authored-by: pshu <pishu.spf@antfin.com>

* release: @umijs/mako@0.9.7

* chore: bundler-mako@0.9.7

* docs: 📝  update changelog for 0.9.7

* chore: ✏️ remove some if (#1706)

* fix: optimization.concatenateModules dts lost (#1708)

* refactor: 🔥 enter ensure 使用 chunk sync dep 减少首屏 chunk 数量 (#1707)

* fix: 🐛 typing of stats (#1712)

* fix: 🐛 detect circular deps output file content (#1715)

* chore: update @umijs/mako typings

* feat: ensure esm imports exists when mode is production (#1709)

* feat: ensure esm imports exists when mode is production

* release: @umijs/mako@0.9.8

* chore: bundler-mako@0.9.8

* docs: update docs

* fix: node ignores (#1716)

* feat: supports publicPath: auto (#1717)

* feat: auto resolve entry file extension (#1718)

* feat: auto resolve entry file extension

* fix: remove useless clone

* Fix/context module source with first empty quasis (#1719)

* test: ✅ add first empty quasis template string module source case

* fix: 🐛 first emtpy quasis case

* fix: inline css config deserialize (#1720)

* fix: node ignore should support node: prefixed only built-in modules (#1721)

* release: @umijs/mako@0.9.9

* docs: suggest using volta to manage node and pnpm's version

* chore: bundler-mako@0.9.9

* docs: update CHANGELOG.md

* feat: supports umd export (#1723)

* feat: supports umd export

* fix: umd config binding typing

* fix: typos

* fix: umd export

* chore: update typings

* fix: replace the "typeof __webpack_require__" content (#1688)

* fix: replace the "typeof __webpack_require__" content

* fix: add some other webpack string name

* fix: 增加对typeof  表达式的处理

* fix: delete log

* fix: rename

---------

Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com>

* fix: umd config deserialization (#1726)

* feat: support case sensitive (#1714)

* feat: add CaseSensitivePlugin

* FIX: update path check

* fix: clippy error

* fix: 调整判断

* fix: 修复目录读取

* fix: 修改参数名称

* fix: 调整测试方式添加e2e断言,并增加配置项只有mac系统下才需要开启相关配置

* fix: 删除过滤条件

* fix: 删除多余测试文件,增加更新内容

* fix:  删除多余log

* fix: 测试执行

* fix: 添加测试系统

* fix: 调整顺序

* fix: 添加测试系统

* fix: 非mac环境断言

* fix: 引用遗漏

* fix: 断言

* fix: 删除默认

* fix: 默认配置

* fix: 测试覆盖

* Revert "fix: 测试覆盖"

This reverts commit b0a2e66.

---------

Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com>

* refactor: 🔥 remove unecessary transform (#1727)

* feat: output filename (#1725)

* refactor: 🎨 add file name template and chunk name in ChunkFile struct

* feat: ✨ add config to output#filename

* feat: ✨ render filename when output#filename configed

* feat: ✨ calc hash in ast impl for entry

* test: ✅ add test case

* test: ✅ add ut

* chore: 🔧 disable codecov error

* refactor: 🎨 remove clone

* fix: 🐛 hash when necessary

* chore: 🔧 add codecov.yml

* release: @umijs/mako@0.9.10-canary.20241218.1

* chore: ⬆️ update pnpm-lock

* feat: native plugin init  (#1691)

* feat: init rust plugin

* chore: delete print

* Rename cargo.toml to Cargo.toml

* chore: update

* fix: type

* fix: plugin options string

* fix: cfg test

* release: @umijs/mako@0.10.0

* chore: bundler-mako@0.10.0

* docs: 📝 changelog 2024.12.20

* chore: 🔧 for quick setup dep to debug (#1733)

* fix: support optional chaining in environment variable (#1730)

* fix: support optional chaining in environment variable

* test(): add edge cases for optional chaining in env_replacer

* refactor: 🎨 no need to resolve empty url in css (#1732)

* refactor: 🎨 no need to resolve empty url in css

* refactor: 🎨 add test case

* feat: support unplugin context (#1728)

* feat: support plugin context

* fix: napi context

* chore: revert changes

* chore: improve

* feat: add error

* feat: warn and error support object

* feat: support emit_file

* ci: fix test

* chore: improve

* chore: update test

* chore: format

* chore: don't support add watch file

* feat: load and transform adapter, and add unplugin-replace example

* chore: test unplugin-icons

* chore: update pnpm-lock.yaml

* docs: improve

---------

Co-authored-by: xusd320 <xusd320@gmail.com>

* fix: legacy octal escape is not permitted in strict mode (#1736)

* fix: legacy octal escape is not permitted in strict mode

* fix: e2e inline css

* release: @umijs/mako@0.11.0

* chore: bundler-mako@0.11.0

* fix: pnpm lock

* docs: 📝 changelog 2024.12.26

* Revert "feat: support unplugin context (#1728)" (#1737)

This reverts commit 3dd6d9d.

* release: @umijs/mako@0.11.1

* chore: bundler-mako@0.11.1

* feat: support unplugin context (#1741)

* feat: support plugin context

* fix: napi context

* chore: revert changes

* chore: improve

* feat: add error

* feat: warn and error support object

* feat: support emit_file

* ci: fix test

* chore: improve

* chore: update test

* chore: format

* chore: don't support add watch file

* feat: load and transform adapter, and add unplugin-replace example

* chore: test unplugin-icons

* chore: update pnpm-lock.yaml

* docs: improve

---------

Co-authored-by: xusd320 <xusd320@gmail.com>

* fix: #1007 (#1738)

support BinaryExpression

Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com>

* fix: win path problem with context module and require context (#1742)

* chore(mako): add debug notice for local builds (#1743)

* fix: normalize Windows paths in ModuleId constructors (#1744)

* fix: normalize Windows paths in Compiler output path handling (#1745)

* fix: typos

* release: @umijs/mako@0.11.2

* chore: bundler-mako@0.11.2

* docs: update CHANGELOG.md

* feat(create-mako): refactor create-mako (#1751)

* chore: add issue and pull request templates for better contribution guidelines (#1753)

* fix: ensure parent directories are created when writing to disk in MemoryChunkFileCache (#1755)

* chore: release @umijs/tools

* release: @umijs/mako@0.11.3

* chore: update the release introduction

* ci: fix ci (#1758)

* chore: upgrade @umijs/tools and do github release and changelog generate and translation by script

* docs: changelog for 0.11.3

* chore: add check-ecosystem-usages script (#1759)

* fix: analyze don't work in safari (#1761)

* fix(mako): cli delay exit (#1762)

* dep: @umijs/tools@0.1.23

* fix: load wasm (#1705)

* fix: 修复load .wasm文件对importObject的处理

* fix: 删除没必要的输出

* fix: 修改生成的成员表达式js代码

* fix: 变量重命名

* fix: 修复代码lint报错

* test: 补充wasm_runtime测试用例

* chore: 补充import js方式的示例

* chore: 修改import js示例wasm产物格式

* chore: wasmparser依赖包在配置文件的位置

* chore: 删除多余的.wasm load逻辑

---------

Co-authored-by: xusd320 <xusd320@gmail.com>

* fix: chunk groups' order when building mpa (#1763)

* feat(copy): support advanced copy configuration with custom target paths (#1711)

* feat(copy): support advanced copy configuration with custom target paths

- Add CopyConfig enum to support both basic and advanced copy modes
- Basic mode: maintains backward compatibility with string[] format
- Advanced mode: supports {from: string, to: string} format for custom paths
- Update copy plugin to handle both configuration formats
- Ensure target directories are created automatically

Example config:
{
  'copy': [
    'public',                              // basic mode
    { 'from': 'assets', 'to': 'static' }  // advanced mode
  ]
}

* fix(copy): prevent path traversal in copy plugin

Add path canonicalization and validation to ensure target paths remain within the destination directory

* chore: Update `copy` config type in Mako bundler

- Updated the type of the `copy` property in the `BuildParams` interface to support both `string` and `{ from: string; to: string }`.
- Ensured the `copy` configuration is properly validated to handle both types.

* docs: Update `copy` config type in documentation

- Updated the `copy` property type in the configuration documentation to reflect the change from `string[]` to `(string | { from: string; to: string })[]`.
- Clarified that the `copy` configuration can now accept both strings and objects with `from` and `to` properties.

* test(copy): add e2e tests for copy plugin from/to pattern

- Update config.copy test fixtures to cover from/to pattern
- Add assertions for copied files in new location
- Adjust copy plugin path validation

* fix(copy): improve path validation and cleanup for copy plugin

- Add directory cleanup when path validation fails
- Use canonicalized paths for more reliable path validation
- Add concatenateModules option type to BuildParams

* fix: ci (#1768)

* release: @umijs/mako@0.11.4

* chore: bump version

* docs: 📝 changelog 2025.02.12

* chore: update changelog 2025.02.12

* fix: plugin context gc (#1769)

* fix: mako已经支持了scss 但是没有支持module.scss文件 (#1770)

Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com>

* feat: add module federation plugin (#1764)

* feat: support module federation

* feat: mf exposes to remote entries

* chore: code styles

* feat: mf container entry impl

* fix: mf container entry

* fix: mf runtime initOptions

* feat: add containter references

* feat: impl mf remote

* feat: improve mf exposes

* fix: mf exposes runtime factory

* fix: mf plugin execution order

* chore: update mf demo

* feat: generate mf manifest in rust

* fix: remote stats.json

* refactor: code styles

* chore: add some FIXME

* refactor: mf plugin mods files

* refactor: mf plugin mods files

* chore: remove dead code

* --wip-- [skip ci]

* fix: remote stats.json

* fix: typos

* chore: simpify mf runtime codes fmt

* refactor: mf containter plugin

* feat: mf shared workaround

* feat: mf shared workaround

* fix: runtime template and remove some useless codes

* fix: mf dev server

* fix: mf shared config

* feat: supports chunk group exclude

* feat: mf patch code splitting

* feat: mf shared manifest

* feat: add config hash for mf shared module

* chore: update mako typings

* chore: code styles

* chore: fix typo

* chore: code styles

* perf: improve performance

* chore: code styles

* chore: rename types

* feat: add options to disable mf manifest

* feat: entry config should be defined as BTreeMap

* fix: mf shared consume and supports eager config

* fix: mf shared eager

* fix: not generate chunk for mf remote module

* fix: typos

* feat: add entry filename supports

* chore: remove meaning less changes

* fix: entry filename and mf config

* release: @umijs/mako@0.11.4-canary.20250206.0

* fix: ignore shared dep when it is been external

* Revert "release: @umijs/mako@0.11.4-canary.20250206.0"

This reverts commit d3105d9.

* release: @umijs/mako@0.11.4-canary.20250207.0

* fix: skip serialize mf manifest remoteEntry if none

* fix: mf manifest remoteEntry address

* Revert "release: @umijs/mako@0.11.4-canary.20250207.0"

This reverts commit 6179982.

* fix: typo

* fix: mako mf manifest publicPath

* fix: mf manifest panic

* fix: mf typings

* test: add e2e test for mf

* fix: typo

* chore: update README

* fix: update mf bingding typings

* fix: typings

* fix: should not generate mf remotes runtime when remotes is empty

* chore: remote wrong comment

* feat: add chunk matcher for mf

* fix: mf binding typings

* chore: remove debug print statements

* docs: update moduleFederation configuration docs

* fix: mf config docs

* chore: update CONTRIBUTING.md

* release: @umijs/mako@0.11.5

* chore: update CHANGELOG.md and versions

* feat: support to disable camel2DashComponentName of transformImport (#1773)

* feat: support to disable camel2DashComponentName of transformImport

* fix: typings

* fix: 修复sass/less-loader的路径解析 (#1771)

* fix: 支持webpack中sass-loader的路径解析

* chore: 调整目录

* chore: 移除注释等

* chore: 引入loader-runner

* chore: sass-loader

* chore: 修改loader返回空值处理

* test: 设置loader resolver的别名

* chore: update lock

* fix: loader options

* refactor: 提取插件代码

* fix: getResolve

* fix: 修复runLoaders中的错误处理逻辑

* release: @umijs/mako@0.11.6

* fix: pnpm-lock

* chore: update changelog for v0.11.6

* chore: update changelog for v0.11.6

* chore: update changelog for v0.11.6

* fix: watch less and sass dependencies (#1779)

* chore: stash

* chore: stash

* feat: LessModuleGraph

* feat: less-import-plugin

* chore: 删除多余代码

* fix: 兼容url()

* chore: plugin

* feat: add beforeRebuild hook

* ci: clippy format

* fix: paths去重

* fix: rename _path

* chore: rust层增加临时过滤文件方式

* chore: 提取createParallelLoader

* refactor: before_rebuild hook (#1785)

* refactor: before_rebuild hook -n

* fix: typos

* feat: postcss-loader (#1787)

* feat: 支持postcss-loader

* chore: 合并postcss到options传给render

* chore: 更新.gitignore以排除less.postcss的node_modules目录

* feat: 添加PostCSS插件支持并更新相关类型定义

* refactor: 简化Less和Sass插件中的选项传递

* docs: 添加postcss支持的配置说明

* feat: 添加对PostCSS的支持,更新相关插件以集成postLoaders

* feat: 更新Less和Sass插件以移除postLoaders,增强PostCSS支持

* test: 补充postcss测试用例

* fix: use transpiled hmr runtime (#1813)

* fix: use transpiled hmr runtime (#1814)

* release: @umijs/mako@0.11.7

* fix: package-lock.json

* fix: use transpiled hmr runtime entry (#1815)

* fix: disable parallel sassLoader because sassOptions.function cann't be shared cross workers (#1816)

* release: @umijs/mako@0.11.8

* fix: package-lock.json

* fix: package-lock.json

* fix: typos

* chore: update changelog for v0.11.8

* fix: less,sass,postcss loader panic (#1818)

* release: @umijs/mako@0.11.9

* fix: package-lock.json

* chore: update changelog for v0.11.9

* fix: worker threads panic on linux (#1823)

* release: @umijs/mako@0.11.10

* fix: package-lock.json

* chore: update changelog for v0.11.10

* fix: dev支持inline-source-map (#1859)

Co-authored-by: dongqing.mdq <dongqing.mdq@antgroup.com>

* release: @umijs/mako@0.11.11

* fix: package-lock.json

* chore: update changelog for v0.11.11

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* fix: less resolve alias (#1906)

* docs: update README.md (#1907)

* Update README.md

* Apply suggestions from code review

Co-authored-by: Peach <scdzwyxst@gmail.com>

* Update README.md

* Update README.md

---------

Co-authored-by: Peach <scdzwyxst@gmail.com>

* Update README.md

* Update README.md

* release: @umijs/mako@0.11.12

* feat: update pnpm log

* chore: update changelog for v0.11.12

* fix: panic on docker linux (#1909)

* doc: add openomy (#1910)

* release: @umijs/mako@0.11.13

* chore: update changelog for v0.11.13

* chore: remove codecov

* chore: update examples/multiple-entries-heavy

* feat: support inline-source-map devtool option (#1965)

Co-authored-by: hanzebang.hzb <hanzebang.hzb@antgroup.com>

* chore: truncate old codes

---------

Co-authored-by: pshu <pishu.spf@antfin.com>
Co-authored-by: chencheng (云谦) <sorrycc@gmail.com>
Co-authored-by: Jinbao1001 <nodewebli@gmail.com>
Co-authored-by: money <hualigushi@163.com>
Co-authored-by: eisonhower <why490078184@gmail.com>
Co-authored-by: huanyu.why <huanyu.why@antgroup.com>
Co-authored-by: PeachScript <scdzwyxst@gmail.com>
Co-authored-by: Wu-kung <1434246346@qq.com>
Co-authored-by: 聪小陈 <xiaohuoni@users.noreply.github.com>
Co-authored-by: akitaSummer <akitasummer@outlook.com>
Co-authored-by: Shi Kuan <shikuan1992@gmail.com>
Co-authored-by: shikuan.sk <shikuan.sk@antgroup.com>
Co-authored-by: yezao <75713784+yezaoshu@users.noreply.github.com>
Co-authored-by: 御风 <18012261618@126.com>
Co-authored-by: bqxbqx <132878537+BQXBQX@users.noreply.github.com>
Co-authored-by: miaodongqing <dongqing_miao@163.com>
Co-authored-by: dongqing.mdq <dongqing.mdq@antgroup.com>
Co-authored-by: kiner-tang(星河) <1127031143@qq.com>
Co-authored-by: hanzebang <46307343+hanzebang@users.noreply.github.com>
Co-authored-by: hanzebang.hzb <hanzebang.hzb@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

copy只支持string[],在需要转换文件名或者目录层次上不太方便,是不是可以扩展到也支持{from:string,to:string}[]

2 participants